Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some effort to compile on windows #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adding iconv only for windows
  • Loading branch information
Kreijstal committed Dec 28, 2023
commit 034fb2a5f102c37ff928fbb54dcc797989e162a4
10 changes: 7 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
@@ -30,12 +30,15 @@ include Makefile.cfg

export CC = gcc -pthread
export CFLAGS += -I. -Wall -Os -ggdb -D_GNU_SOURCE -fPIC
export LDLIBS += $(shell pkg-config --libs ncursesw iconv)
export CFLAGS += $(shell pkg-config --cflags ncursesw iconv)
export LDLIBS += $(shell pkg-config --libs ncursesw)
export CFLAGS += $(shell pkg-config --cflags ncursesw)
VERSION := 0.24
ifeq ($(detected_OS),Windows)
SHARED_LIB_NAME := libstfl.$(VERSION).$(SHARED_LIB_EXT)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHARED_LIB_EXT is only used here. How about hard-coding it to dll here and removing the variable?

CFLAGS += -DNCURSES_STATIC
export LDLIBS += $(shell pkg-config --libs iconv)
export CFLAGS += $(shell pkg-config --cflags iconv)
VERSION := 0.24
else
SHARED_LIB_NAME := libstfl.so.$(VERSION)
SONAME := libstfl.so.0
@@ -96,10 +99,11 @@ ifeq ($(FOUND_SPL),1)
include spl/Makefile.snippet
endif

ifneq ($(detected_OS),Windows)
ifeq ($(FOUND_SWIG)$(FOUND_PERL5),11)
include perl5/Makefile.snippet
endif

endif
ifeq ($(FOUND_SWIG)$(FOUND_PYTHON),11)
include python/Makefile.snippet
endif