Skip to content

Commit

Permalink
fixed unitywebrequest instrumentation issue where call virt instructi…
Browse files Browse the repository at this point in the history
…ons were replaced by call instructions. (#9)
  • Loading branch information
ndesai-newrelic committed Feb 22, 2024
1 parent 225f130 commit 2380836
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 6 deletions.
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
## 1.3.1

- Resolved an issue in UnityWebRequest instrumentation where "callvirt" instructions were erroneously replaced with "call" instructions.

## 1.3.0

- Resolved an issue with the application framework that was causing unexpected behavior.
- Fixed a bug in the application log received handler, ensuring accurate and reliable logging.
- Addressed a build issue that was causing problems with the iOS app.

## 1.0.0

🎉🎊 Presenting the new NewRelic SDK for Unity:
Expand Down
2 changes: 1 addition & 1 deletion com.newrelic.agent/Scripts/Networking/AutoInjection.cs
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ private static void InjectIntoAssembly(AssemblyDefinition assemblyDefinition)
foreach (var instructionToReplace in disposeWebRequestInstructionsToReplace)
{
Debug.Log("******* Replacing UnityWebRequst::DisposeWebRequestCall with wrapper call. *******");
var callWrapperInstruction = iLProcessor.Create(Mono.Cecil.Cil.OpCodes.Call, disposeWebRequestWrapperMethodReference);
var callWrapperInstruction = iLProcessor.Create(Mono.Cecil.Cil.OpCodes.Callvirt, disposeWebRequestWrapperMethodReference);
iLProcessor.Replace(instructionToReplace, callWrapperInstruction);
}

Expand Down
12 changes: 7 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,20 +1,22 @@
{
"name": "com.newrelic.agent",
"version": "1.3.0",
"version": "1.3.1",
"displayName": "NewRelic SDK",
"description": "NewRelic's Unity SDK lets you bring the deep, introspective and native debugging power of NewRelic into your Unity game or application.",
"unity": "2019.1",
"unityRelease": "0f2",
"documentationUrl": "",
"changelogUrl": "",
"licensesUrl": "",
"documentationUrl": "https://docs.newrelic.com/docs/mobile-monitoring/new-relic-mobile-unity/monitor-your-unity-application/",
"changelogUrl": "https://github.com/newrelic/newrelic-unity-agent/blob/main/CHANGELOG.md",
"licensesUrl": "https://github.com/newrelic/newrelic-unity-agent/blob/main/LICENSE",
"keywords": [
"newrelic",
"anr",
"crashes",
"bugs",
"network monitoring",
"handle exceptions"
"handle exceptions",
"games",
"mobile games"
],
"author": {
"name": "NewRelic",
Expand Down

0 comments on commit 2380836

Please sign in to comment.