Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) made boolean omitempty values references #950

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

amaor-newrelic
Copy link
Contributor

@amaor-newrelic amaor-newrelic commented Nov 8, 2022

THIS IS A BREAKING CHANGE
This PR addresses a number of issues with the API used to update channels and destinations

  1. It was impossible to update any boolean field from true to false
  2. Empty filter was not marshalled correctly
    Unfortunately, it was impossible to implement these changes in a backward-compatible way. The current API is just does not match our GraphQL API.

See this pr for reference

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ amaor-newrelic
❌ mbazhlekova
You have signed the CLA already but the status is still pending? Let us recheck it.

@amaor-newrelic amaor-newrelic force-pushed the fix-channel-active-marshalling-issues branch from ade6c5f to ef7e27c Compare November 8, 2022 14:08
@mbazhlekova
Copy link
Contributor

@amaor-newrelic Thank you for your contribution! Sorry for the delay on this. We're doing some feature work that we're hoping to get into v2 before releasing another major version since it's a bit of a hassle in Go. Happy to review once that work is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants