Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Set NEW_RELIC_APP_NAME automatically from Pod Labels #83

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ramkrishankumarN
Copy link
Contributor

@ramkrishankumarN ramkrishankumarN commented Aug 30, 2024

Description

If the deployment yaml has the following params already

template:
   metadata:
     labels:
       app: busybox
       app.kubernetes.io/name: busybox

then, automatically, infer the NEW_RELIC_APP_NAME as busybox and populate those as to the app.kubernetes.io/name so, in this case NEW_RELIC_APP_NAME will be set to busybox

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@ramkrishankumarN ramkrishankumarN requested a review from a team as a code owner August 30, 2024 20:52
@ramkrishankumarN ramkrishankumarN changed the title Set NEW_RELIC_APP_NAME automatically from Pod Labels [k8s-operator] Set NEW_RELIC_APP_NAME automatically from Pod Labels Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.81%. Comparing base (64e82f2) to head (3db11ba).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   47.43%   47.81%   +0.37%     
==========================================
  Files          13       13              
  Lines         976      983       +7     
==========================================
+ Hits          463      470       +7     
  Misses        448      448              
  Partials       65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramkrishankumarN ramkrishankumarN changed the title [k8s-operator] Set NEW_RELIC_APP_NAME automatically from Pod Labels feat:[k8s-operator] Set NEW_RELIC_APP_NAME automatically from Pod Labels Aug 30, 2024
@dbudziwojskiNR dbudziwojskiNR changed the title feat:[k8s-operator] Set NEW_RELIC_APP_NAME automatically from Pod Labels feat: Set NEW_RELIC_APP_NAME automatically from Pod Labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant