Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): post-release fixes to ANR doc #17861

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

ally-sassman
Copy link
Contributor

There are a few post-release updates needed:

  • Update screenshots, size down the too-large ones
  • Fix broken data dictionary link
  • Add more details about server-side configuration
  • Move up ANR page out of the mobile app pages section

@ally-sassman ally-sassman added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Jul 1, 2024
@ally-sassman ally-sassman self-assigned this Jul 1, 2024
@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Jul 1, 2024
@github-actions github-actions bot requested a review from nbaenam July 1, 2024 21:34
Copy link

github-actions bot commented Jul 1, 2024

Hi @ally-sassman 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

@ally-sassman ally-sassman moved this from Hero to triage to Needs review in Docs PRs and Issues Jul 1, 2024
Copy link

netlify bot commented Jul 1, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 59aa693
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/668591e9cfedac0008f6f1b3
😎 Deploy Preview https://deploy-preview-17861--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ally-sassman ally-sassman requested review from silpau-pm and removed request for nbaenam July 2, 2024 16:55
@@ -130,6 +130,10 @@ Server-side mobile agent configuration provides a mechanism to remotely manage a

The following setting can be currently modified remotely on the **Application** page:
* Application Not Responding (ANR) error tracking (Android only): Enables tracking and reporting of the reasons behind ANR errors. This functionality is enabled by default and requires Android agent 7.4.1 or higher.
<Callout variant="important">
Server-side configuration always take precedence over local agent configuration.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add this at the end & link it - " For more information about how server-side configuration for mobile works , refer here (link the server side configuration in mobile monitoring settings here)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silpau-pm This will already be on the settings page (/docs/mobile-monitoring/new-relic-mobile/maintenance/configure-settings-for-mobile-monitoring)

jeff-colucci
jeff-colucci previously approved these changes Jul 2, 2024
Copy link
Contributor

@jeff-colucci jeff-colucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I just found one small thing that might need to be addressed but once it's fixed (if you decide to change it) you're good to publish from a writer's perspective!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants