-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add popover and create a test popover link out #17790
base: develop
Are you sure you want to change the base?
Conversation
Hi @akristen 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/data/popovers_en.json
Outdated
@@ -139,5 +139,16 @@ | |||
"primaryButton": "Read the tutorial", | |||
"primaryButtonUrl": "https://docs.newrelic.com/docs/tutorial-create-alerts/create-new-relic-alerts/" | |||
} | |||
} | |||
}, | |||
"nerdgraphExplorer": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's code it as nerdGraph
or similar, not explorer.
Co-authored-by: Austin Schaefer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akristen I took a spin through this. Let's chat about these related changes you might make.
@@ -180,7 +180,7 @@ To get started with API keys: | |||
|
|||
You can view and manage most API keys from the [API keys UI page](https://one.newrelic.com/api-keys). To find that: from the [user menu](/docs/accounts/accounts-billing/general-account-settings/intro-account-settings/#user-menu), click <DoNotTranslate>**API keys**</DoNotTranslate>. You can also: | |||
|
|||
* [Use NerdGraph explorer to view and create](/docs/apis/nerdgraph/get-started/introduction-new-relic-nerdgraph#explorer) user keys | |||
* Use <InlinePopover type="nerdgraph" /> to view and create user keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akristen I know you didn't compose these two bullets, but aren't they saying the same thing?
I had recently written a revamp of this page that moved this "Manage" section to the list in the introduction about managing keys.
Also, you could move that reference to Account ID into the table of keys. There's no reason to have it orphaned like this.
Co-authored-by: Rob Siebens <[email protected]>
Co-authored-by: Rob Siebens <[email protected]>
nerdgraph explorer popover