Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add popover and create a test popover link out #17790

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Conversation

akristen
Copy link
Contributor

nerdgraph explorer popover

Copy link

Hi @akristen 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Jun 26, 2024
Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit c9137af
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/6684879abe908a000855a465
😎 Deploy Preview https://deploy-preview-17790--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rhetoric101 rhetoric101 moved this from Hero to triage to In progress in Docs PRs and Issues Jun 26, 2024
@rhetoric101 rhetoric101 added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Jun 26, 2024
austin-schaefer
austin-schaefer previously approved these changes Jul 2, 2024
src/data/popovers_en.json Outdated Show resolved Hide resolved
src/data/popovers_en.json Outdated Show resolved Hide resolved
@@ -139,5 +139,16 @@
"primaryButton": "Read the tutorial",
"primaryButtonUrl": "https://docs.newrelic.com/docs/tutorial-create-alerts/create-new-relic-alerts/"
}
}
},
"nerdgraphExplorer": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's code it as nerdGraph or similar, not explorer.

Co-authored-by: Austin Schaefer <[email protected]>
src/data/popovers_en.json Outdated Show resolved Hide resolved
src/data/popovers_en.json Outdated Show resolved Hide resolved
Copy link
Contributor

@rhetoric101 rhetoric101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akristen I took a spin through this. Let's chat about these related changes you might make.

src/data/popovers_en.json Outdated Show resolved Hide resolved
src/data/popovers_en.json Outdated Show resolved Hide resolved
@@ -180,7 +180,7 @@ To get started with API keys:

You can view and manage most API keys from the [API keys UI page](https://one.newrelic.com/api-keys). To find that: from the [user menu](/docs/accounts/accounts-billing/general-account-settings/intro-account-settings/#user-menu), click <DoNotTranslate>**API keys**</DoNotTranslate>. You can also:

* [Use NerdGraph explorer to view and create](/docs/apis/nerdgraph/get-started/introduction-new-relic-nerdgraph#explorer) user keys
* Use <InlinePopover type="nerdgraph" /> to view and create user keys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akristen I know you didn't compose these two bullets, but aren't they saying the same thing?

I had recently written a revamp of this page that moved this "Manage" section to the list in the introduction about managing keys.

Also, you could move that reference to Account ID into the table of keys. There's no reason to have it orphaned like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants