Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrites of Vert-x docs #17693

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Rewrites of Vert-x docs #17693

wants to merge 3 commits into from

Conversation

bradleycamacho
Copy link
Contributor

This pr rewrites parts fo the Vert-x docs. Still needs nav work.

Copy link

Hi @bradleycamacho 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

@github-actions github-actions bot added this to Hero to triage in Docs PRs and Issues Jun 18, 2024
Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 57aff45
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/66759e0a6fa1e000088c9d3a
😎 Deploy Preview https://deploy-preview-17693--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@akristen akristen added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Jun 18, 2024
@akristen akristen moved this from Hero to triage to In progress in Docs PRs and Issues Jun 18, 2024
---

[Java Vert.x Event Bus Integration](https://github.com/newrelic/newrelic-java-vertx/tree/main) provides instrumentation for monitoring the (Vert.x)[https://vertx.io/] Event Bus, enabling the tracking of event flow across the bus. Specifically designed for Vert.x Verticles that extend` AbstractVerticle`, this extension instruments each deployed class to monitor all methods except those specifically defined by `AbstractVerticle`.
[Java Vert.x Event Bus Integration](https://github.com/newrelic/newrelic-java-vertx/tree/main) provides instrumentation for monitoring the [Vert.x](https://vertx.io/) Event Bus by enabling the tracking of event flow across the bus. Specifically designed for Vert.x Verticles that extend `AbstractVerticle`, this extension instruments each deployed class to monitor all methods except those specifically defined by `AbstractVerticle`.
Copy link
Contributor

@akristen akristen Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Java Vert.x Event Bus Integration](https://github.com/newrelic/newrelic-java-vertx/tree/main) provides instrumentation for monitoring the [Vert.x](https://vertx.io/) Event Bus by enabling the tracking of event flow across the bus. Specifically designed for Vert.x Verticles that extend `AbstractVerticle`, this extension instruments each deployed class to monitor all methods except those specifically defined by `AbstractVerticle`.
[Java Vert.x Event Bus integration](https://github.com/newrelic/newrelic-java-vertx/tree/main) instruments the [Vert.x](https://vertx.io/) Event Bus. When you install the integration, you enable tracking of event flow across the bus. This integration is specifically designed for Vert.x Verticles that extend `AbstractVerticle`, instrumenting each deployed class for all methods, unlesss defined otherwise by `AbstractVerticle`.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I broke up this intro sentence a little bit and chunked out the functionality. feel free to further edit etc -- mostly i just think it's a LOT of information shoved into a couple sentences, which is great, but i think for clarity can be broken up a bit

---

[Java Vert.x Event Bus Integration](https://github.com/newrelic/newrelic-java-vertx/tree/main) provides instrumentation for monitoring the (Vert.x)[https://vertx.io/] Event Bus, enabling the tracking of event flow across the bus. Specifically designed for Vert.x Verticles that extend` AbstractVerticle`, this extension instruments each deployed class to monitor all methods except those specifically defined by `AbstractVerticle`.
[Java Vert.x Event Bus Integration](https://github.com/newrelic/newrelic-java-vertx/tree/main) provides instrumentation for monitoring the [Vert.x](https://vertx.io/) Event Bus by enabling the tracking of event flow across the bus. Specifically designed for Vert.x Verticles that extend `AbstractVerticle`, this extension instruments each deployed class to monitor all methods except those specifically defined by `AbstractVerticle`.

## Supported methods
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anchor tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants