Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pt3dstyle logical connection should be at center of soma section (instead of center of contour). #2981

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

nrnhines
Copy link
Member

@nrnhines nrnhines commented Jul 13, 2024

Closes #2973

The logical connection after import3d neurolucida3 file should be invariant on h.define_shape().
That is, the location of the rest of the tree should not change relative to the soma.

This is accomplished by updating the logical connection point of dendrites at instantiation when the actual 3-d soma section points are known (after processing the contour).

The two (related) substantive changes in this PR are noted in the comments.

Test added

@nrnhines nrnhines changed the title pt3dstyle logical connection should be to center of soma section (instead of center of contour). pt3dstyle logical connection should be at center of soma section (instead of center of contour). Jul 13, 2024
Copy link

✔️ 528f82d -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

src/nrnpython/nrnpy_hoc.cpp Outdated Show resolved Hide resolved
share/lib/hoc/import3d/import3d_gui.hoc Show resolved Hide resolved
@pramodk pramodk closed this Jul 14, 2024
@pramodk pramodk reopened this Jul 14, 2024
Copy link

✔️ 528f82d -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 7b96538 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 5cd3295 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ efc9f28 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@nrnhines
Copy link
Member Author

The many CI failures are perplexing. On my machine I have similar errors for ninja testfor this pr but also for the master. ie. Ubuntu 24.04, gcc version 13.2.0 (Ubuntu 13.2.0-23ubuntu4), Python 3.12.3 (via pyenv)

The following tests FAILED:
	  3 - unit_tests::benchmarks (Failed)
	 86 - parallel::subworld (Failed)
	 88 - parallel::netpar (Failed)
	 89 - parallel::bas (Failed)
	 90 - parallel::nrntest_fast (Failed)
	 92 - nmodl_tests::test_disc (Failed)
	 93 - nmodl_tests::test_function_table (Failed)
	 94 - nmodl_tests::test_kinetic (Failed)
	123 - pyinit::nrniv_py3.12_python_check_sys_path (Failed)
	125 - pyinit::nrniv_py3.12_nrnpython_check_sys_path (Failed)
	127 - pyinit::nrniv_py3.12_python_check_sys_prefix (Failed)
	129 - pyinit::nrniv_py3.12_nrnpython_check_sys_prefix (Failed)
	131 - pyinit::nrniv_py3.12_python_check_sys_exec_prefix (Failed)
	133 - pyinit::nrniv_py3.12_nrnpython_check_sys_exec_prefix (Failed)
	159 - pyinit::nrniv_pydef_python_check_sys_path (Failed)
	161 - pyinit::nrniv_pydef_nrnpython_check_sys_path (Failed)
	163 - pyinit::nrniv_pydef_python_check_sys_prefix (Failed)
	165 - pyinit::nrniv_pydef_nrnpython_check_sys_prefix (Failed)
	167 - pyinit::nrniv_pydef_python_check_sys_exec_prefix (Failed)
	169 - pyinit::nrniv_pydef_nrnpython_check_sys_exec_prefix (Failed)
	194 - external_nrntest (Failed)
	207 - testcorenrn_vecevent::compare_results (Failed)

Copy link

✔️ 3e38a26 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

sonarcloud bot commented Aug 11, 2024

Copy link

✔️ d6fd24b -> Azure artifacts URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong logical connection points for cell imported from neurolucida file
3 participants