OpenMP schedule dynamic for parallelForEdges #819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently used
parallelForEdges
to generate random weights on large graphs (1-2 billion edges). On a 36-cores machine, the performance was very poor (it took >1h) due to bad load balancing (during the last 30 minutes only a few threads were running).The loop iterates over the nodes in parallel and each thread iterates over the neighbors of the current node, so the workload of a thread depends on the degrees of the nodes it processes (which might vary a lot).
Changing the schedule from
guided
todynamic
improved the load balancing and the performance significantly (the time dropped to a few minutes), which makes sense because withguided
some thread might end up processing many more edges than others. So I think we should usedynamic
as the default scheduling strategy for this loop.