Feature/plm with custom initialization #784
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature/PLM-with-custom-initialization
michitux
reviewed
Jul 5, 2021
angriman
reviewed
Aug 13, 2021
| @@ -33,7 +34,7 @@ class PLM final : public CommunityDetectionAlgorithm { | |||
| * @param[in] recurse use recursive coarsening, see http://journals.aps.org/pre/abstract/10.1103/PhysRevE.89.049902 for some explanations (default: true) | |||
| * | |||
| */ | |||
| PLM(const Graph& G, bool refine=false, double gamma = 1.0, std::string par="balanced", count maxIter=32, bool turbo = true, bool recurse = true); | |||
| PLM(const Graph& G, bool refine=false, double gamma = 1.0, std::string par="balanced", count maxIter=32, bool turbo = true, bool recurse = true, Partition zeta=Partition(0)); | |||
There was a problem hiding this comment.
Adding an initial partition looks like a good idea. However, the parameter list is already quite long and setting the partition this way seems inconvenient. What about adding a setInitialPartition method? This method could also be overloaded to also take an rvalue ref, so that we can avoid unnecessary copies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion to add a partition as an optional parameter for the PLM algorithm. This partition can then be used to initialize the PLM.
This is particularly useful (in my case) when dealing with dynamic graphs, to check the influence of new links on current communities.
The PLM run can still be called without a partition and would run as usual; the CI is unaffected.