Improve LAMG helper classes #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
bernlu
force-pushed
the
code-style-performance/improve-lamg-helper-classes
branch
2 times, most recently
from
96e2313
to
b6ab0b4
Compare
fabratu
requested changes
May 13, 2024
specialize SolverLamg.minRes for each Matrix type, because they have different interfaces
bernlu
force-pushed
the
code-style-performance/improve-lamg-helper-classes
branch
from
9726b77
to
95d96d3
Compare
|
To address the comments on variable naming: I agree that the names are not chosen well, but I do not have enough knowledge of the inner workings of this algorithm to understand what the |
fabratu
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various small changes to the LAMG helper classes to improve readability, performance, and allow use in
constcontexts. Also fixes a few problems such that the templateMatrixcan now be any of our matrix classes - and now uses explicit template instantiation to verfiy this.