fix: Publisher not stored if type other than creator (#910)

netwerk-digitaal-erfgoed · May 31, 2024 · 7876d68 · 7876d68
1 parent 165bb7f
commit 7876d68
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/src/query.ts b/src/query.ts
@@ -266,20 +266,19 @@ function schemaOrgQuery(prefix: string): string {
       
     FILTER (!isBlank(?${license}))
 
+    VALUES ?organizationOrPerson { ${prefix}:Organization ${prefix}:Person }          
     OPTIONAL { 
       ?${dataset} ${prefix}:creator ?${creator} .        
       ?${creator} a ?organizationOrPerson ;
         a ?creatorType ; 
         ${prefix}:name ?${creatorName} .
-      VALUES ?organizationOrPerson { ${prefix}:Organization ${prefix}:Person }          
     }
       
     OPTIONAL { 
       ?${dataset} ${prefix}:publisher ?${publisher} .        
       ?${publisher} a ?organizationOrPerson ;
         a ?publisherType ;
         ${prefix}:name ?${publisherName} .
-      VALUES ?organizationOrPerson { ${prefix}:Organization ${prefix}:Person }  
       OPTIONAL {
         ?${publisher} ${prefix}:contactPoint/${prefix}:email ?${publisherEmail} .  
       }

diff --git a/test/datasets/dataset-schema-org-valid.jsonld b/test/datasets/dataset-schema-org-valid.jsonld
@@ -37,7 +37,7 @@
       "name": "Creator 1"
     },
     {
-      "@type": "Organization",
+      "@type": "Person",
       "@id": "https://example.com/creator2",
       "name": "Creator 2"
     }

diff --git a/test/fetch.test.ts b/test/fetch.test.ts
@@ -168,6 +168,16 @@ describe('Fetch', () => {
         )
       )
     ).toBe(true);
+    expect(
+      dataset.has(
+        factory.quad(
+          factory.namedNode('https://example.com/creator2'),
+          rdf('type'),
+          foaf('Person'),
+          factory.namedNode('http://data.bibliotheken.nl/id/dataset/rise-alba')
+        )
+      )
+    ).toBe(true);
     expect([
       ...dataset.match(
         factory.namedNode('http://data.bibliotheken.nl/id/dataset/rise-alba'),