fix(remix-init): add missing dependencies to remix.init script #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remix-edge-on ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for remix-on ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
serhalp
deleted the
michalpiechowiak/frp-1292-remixinit-script-fails-if-chosen-to-run-during-create-remix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
pnpmor other package manager that strongly enforce using only declared dependencies, our current remix.init script fails due to trying to use packages that are transitively used by remix (so it works with npm for example due to way it likes to hoist transitive deps)remix.initscript fails if chosen to run duringcreate-remixbootstrapping #148QA Instructions, Screenshots, Recordings
This can be tested by running
(the branch name is different than from this PR due to
create-remixbug that fails when branch names contain/- remix-run/remix#8151 (comment) but it's otherwise exactly the same).And compare to
pnpm create remix@latest --template netlify/remix-templatewhich does fail.Note for testing - ensure directory where you create app doesn't already exist because weird things happen otherwise. So probably good to
rm -rf my-remix-appbefore usingcreate-remixFor us to review and ship your PR efficiently, please perform the following steps:
can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)