Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove react and react-dom from dependencies #145

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

simplystuart
Copy link
Contributor

Description

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we
    can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • [-] Read the contribution guidelines 📖. This ensures your code follows our style
    guide and passes our tests.
  • [-] Update or add tests (if any source code was changed or added) 🧪
  • [-] Update or add documentation (if features were changed or added) 📝
  • [-] Make sure the status checks below are successful ✅

puppy-eyes

@simplystuart simplystuart requested a review from a team as a code owner April 24, 2024 16:38
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for remix-edge-on ready!

Name Link
🔨 Latest commit f2eb735
🔍 Latest deploy log https://app.netlify.com/sites/remix-edge-on/deploys/66293580ef04d900072cc9e4
😎 Deploy Preview https://deploy-preview-145--remix-edge-on.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 24, 2024

👷 Deploy request for remix-on pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f2eb735

@simplystuart
Copy link
Contributor Author

FYI react and react-dom aren't needed as direct dependencies as @remix-run/react includes both.

@ascorbic
Copy link
Contributor

Thanks, this makes sense

@ascorbic ascorbic changed the title Remove react and react-dom from dependencies fix: remove react and react-dom from dependencies Apr 25, 2024
@kodiakhq kodiakhq bot merged commit 3fbf4c2 into netlify:main Apr 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Edge build throws Unexpected Server Error
2 participants