Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add entry.server.tsx to functions template #140

Closed
wants to merge 1 commit into from

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Mar 29, 2024

Description

Seems like default Remix server entry is behaving weirdly and is not closing connection after send content and only eventually after 5s (default timeout) connection is closed which is reported as slow response ( https://answers.netlify.com/t/remix-very-slow/115440 )

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we
    can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style
    guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@pieh pieh requested a review from a team as a code owner March 29, 2024 17:44
@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Mar 29, 2024
Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for remix-edge-on ready!

Name Link
🔨 Latest commit 51efb7a
🔍 Latest deploy log https://app.netlify.com/sites/remix-edge-on/deploys/6606fe0cb2caa90009e0f8ac
😎 Deploy Preview https://deploy-preview-140--remix-edge-on.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for remix-on ready!

Name Link
🔨 Latest commit 51efb7a
🔍 Latest deploy log https://app.netlify.com/sites/remix-on/deploys/6606fe0cb2caa90009e0f8ae
😎 Deploy Preview https://deploy-preview-140--remix-on.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kennygoff
Copy link

kennygoff commented Mar 30, 2024

Left a comment on that Support thread with this but the remix-adapter already exports this functionality in handleRequest and old versions of the template (see a5ca44) have a single-line re-export.

Should go back to this for remix.init/functions/app/entry.server.tsx:

export { handleRequest as default } from "@netlify/remix-adapter";

And according to this guide, remix.init/edge/app/entry.server.tsx should be updated. Although the adapter also still has a remix-edge version of handleRequest which would conflict with the original version.

// @ts-expect-error virtual module
// eslint-disable-next-line import/no-unresolved
export { default } from "virtual:netlify-server-entry";

The old version for reference:

export { handleRequest as default } from "@netlify/remix-edge-adapter";

@pieh pieh closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants