feat: replace _redirects workaround with preferStatic #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for remix-edge-on ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for remix-on ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
type: feature
|
Oh hey, there's deploy previews for this site - neat! Looks like it's working alright :D |
ascorbic
reviewed
Dec 14, 2023
|
We've started deleting |
ascorbic
approved these changes
Dec 14, 2023
|
I've not tested this, but approving on the basis that you've tested the template in dev locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's important that the SSR function matches all paths, except for the ones that have static files. In the past,
_redirectswas the way to achieve that - but with V2 Functions, in-source-config is much easier to reason about. Now that we havepreferStatic, we can scratch the_redirectsworkaround and use in-source-config instead!Keeping this as draft until i've manually verified that it works as intended. One of the challenges is that the Remix compiler will turn
trueinto!0, but netlify/zip-it-and-ship-it#1665 should help us handle that.