feat!: update to Remix 2 #128
Conversation
✅ Deploy Preview for remix-edge-on ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
type: feature
| @@ -2,6 +2,11 @@ | |||
| command = "npm run build" | |||
| publish = "public" | |||
|
|
|||
| [dev] | |||
| command = "npm run dev" | |||
There was a problem hiding this comment.
We no longer run a dev command - ntl is spawned by remix
✅ Deploy Preview for remix-on ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
app/entry.client.tsx
Outdated
There was a problem hiding this comment.
This is the new default in Remix
| status: responseStatusCode, | ||
| }); | ||
| } | ||
| export { handleRequest as default } from "@netlify/remix-adapter"; |
There was a problem hiding this comment.
We now define the handler in the adapter, so this is all that's needed!
| netlify dev | ||
| npm run dev |
There was a problem hiding this comment.
We use the new v2 dev mode, which allows remiox dev to run a custom server, which in our case is ntl dev. For that reason we dont want them running it themselves
| const foldersToExclude = [".github", ".git"]; | ||
| const foldersToExclude = [".github"]; |
There was a problem hiding this comment.
The .git dir is created by Remix, and is this site's initial commit
| @@ -116,6 +125,7 @@ async function main({ rootDirectory }) { | |||
| rootDirectory, | |||
| }); | |||
| await updatePackageJsonForFunctions(rootDirectory); | |||
| await installAdditionalDependencies({ rootDirectory, packageManager }); | |||
There was a problem hiding this comment.
Both runtimes need an extra install step
| const handler = createRequestHandler({ | ||
| build, | ||
| mode: process.env.NODE_ENV, | ||
| }); | ||
|
|
||
| export default handler; |
There was a problem hiding this comment.
It doesn't recognise it as a v2 function if we export it directly, so we assign to a var and export that
Description
Updates the templates for Remix 2. This includes:
entry.server.tswith a re-export from the adapters