chore: infer tmp directory name from test name everywhere #6566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃搳 Benchmark resultsComparing with 5e716c0
|
ericapisani
previously approved these changes
May 8, 2024
|
There's a test failure that looks like it might be legit but otherwise LGTM |
mrstork
previously approved these changes
May 8, 2024
mrstork
approved these changes
May 13, 2024
Skn0tt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some flaky tests on main, that are being flaky because they're reusing the same directory across multiple, concurrent tests. In bad race conditions, this means the directory is being cleaned up by one test, while a different test still uses it 馃挜
fa5de3b contains a fix, where we're not specifying the directory name by hand, but we use the test name as a basis for it. And because i'm a little annoyed this happened in the first place, i'm also replacing all other usage of
withSiteBuilder(string)in f625203.