Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @netlify/build to 29.21.1 #5997

Closed
wants to merge 1 commit into from

Conversation

estephinson
Copy link
Contributor

@estephinson estephinson commented Sep 15, 2023

πŸŽ‰ Thanks for submitting a pull request! πŸŽ‰

Summary

Bump because renovate sad


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

@estephinson estephinson requested a review from a team as a code owner September 15, 2023 14:43
@github-actions
Copy link

πŸ“Š Benchmark results

Comparing with da54676

  • Dependency count: 1,365 (no change)
  • Package size: 366 MB (no change)

Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see in #986 that the update was picked up by Renovate, but it was rate-limited. You can click on the checkbox next to the package to force it to create the PR.

If you do decide to do the update manually (which I would avoid if you can help it), I would use a fix: or feat: prefix or release-please won't generate a release. Also, we're currently pinning @netlify/build to a specific version and you're changing it to a range here.

@estephinson
Copy link
Contributor Author

I am a renovate newbie so I really appreciate that - I was triggering it a billion times via the dashboard but every time coming up that it was skipping. Had a google and found nothing related to that, really appreciate the pointer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants