Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CMake options for platform-dependent plugins depend on being build for a supported platform. #17517

Merged
merged 2 commits into from
May 21, 2024
Merged

Make CMake options for platform-dependent plugins depend on being build for a supported platform. #17517

merged 2 commits into from
May 21, 2024

Commits on May 20, 2024

  1. Move OS detection above option definitions. 

    This will allow us to use the target platform to decide what options to
actually show to users.
    @Ferroin
    Ferroin committed May 20, 2024
    Configuration menu
    Copy the full SHA
    8dd7bd6 View commit details
    Browse the repository at this point in the history

  2. Make plugin options depend on the platforms that we support them on. 

    This way users will only be able to enable plugins that will actually
work on their system.
    @Ferroin
    Ferroin committed May 20, 2024
    Configuration menu
    Copy the full SHA
    856d3d6 View commit details
    Browse the repository at this point in the history