profiles: firecfg: disable text editors #6477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if I missed any text editor. |
rusty-snake
approved these changes
Sep 14, 2024
kmk3
force-pushed
the
firecfg-disable-text-editors
branch
2 times, most recently
from
0944ef0
to
b13975f
Compare
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Sep 19, 2024
This test started failing today with "TESTING ERROR 3". Log from a CI re-run of test-fs on commit 897f12d ("build(deps): bump step-security/harden-runner from 2.9.0 to 2.9.1", 2024-09-01) / PR netblue30#6455[1]: 2024-09-19T13:39:04.5681290Z TESTING: private home (test/fs/private-home.exp) 2024-09-19T13:39:04.5713434Z spawn /bin/bash 2024-09-19T13:39:05.2772248Z touch ~/_firejail_test_file1 2024-09-19T13:39:05.2773779Z runner@fv-az1247-944:~/work/firejail/firejail/test/fs$ 2024-09-19T13:39:05.2774475Z <jail/firejail/test/fs$ touch ~/_firejail_test_file1 2024-09-19T13:39:05.2775175Z runner@fv-az1247-944:~/work/firejail/firejail/test/fs$ 2024-09-19T13:39:05.2776506Z <jail/firejail/test/fs$ touch ~/_firejail_test_file2 2024-09-19T13:39:05.2777841Z runner@fv-az1247-944:~/work/firejail/firejail/test/fs$ 2024-09-19T13:39:05.2778918Z <ejail/firejail/test/fs$ mkdir ~/_firejail_test_dir1 2024-09-19T13:39:05.2780080Z runner@fv-az1247-944:~/work/firejail/firejail/test/fs$ 2024-09-19T13:39:05.2780903Z <fs$ mkdir ~/_firejail_test_dir1/_firejail_test_dir2 2024-09-19T13:39:05.2781613Z runner@fv-az1247-944:~/work/firejail/firejail/test/fs$ 2024-09-19T13:39:05.2782461Z <_test_dir1/_firejail_test_dir2/_firejail_test_file3 2024-09-19T13:39:05.2783224Z runner@fv-az1247-944:~/work/firejail/firejail/test/fs$ 2024-09-19T13:39:05.2784047Z <firejail/test/fs$ ln -s /etc ~/_firejail_test_link1 2024-09-19T13:39:05.2784851Z runner@fv-az1247-944:~/work/firejail/firejail/test/fs$ 2024-09-19T13:39:05.2785861Z < ln -s ~/_firejail_test_dir1 ~/_firejail_test_link2 2024-09-19T13:39:05.2787008Z runner@fv-az1247-944:~/work/firejail/firejail/test/fs$ 2024-09-19T13:39:05.2788303Z <test_file1,_firejail_test_file2,_firejail_test_dir1 [...] 2024-09-19T13:39:05.4971716Z runner@fv-az1247-944:~$ find ~ 2024-09-19T13:39:05.4989255Z /home/runner 2024-09-19T13:39:05.4990116Z /home/runner/_firejail_test_file1 2024-09-19T13:39:05.4990768Z /home/runner/_firejail_test_file2 2024-09-19T13:39:05.4991299Z /home/runner/_firejail_test_dir1 2024-09-19T13:39:05.4992082Z /home/runner/_firejail_test_dir1/_firejail_test_dir2 2024-09-19T13:39:05.4992760Z /home/runner/_firejail_test_dir1/_firejail_test_dir2/_firejail_test_file3 [...] 2024-09-19T13:39:15.4995765Z runner@fv-az1247-944:~$ TESTING ERROR 3 2024-09-19T13:39:15.5000367Z Misc: This was noticed on netblue30#6477. [1] https://github.com/netblue30/firejail/actions/runs/10655583953/job/30378507249
kmk3
force-pushed
the
firecfg-disable-text-editors
branch
from
b13975f
to
07ea54c
Compare
Disable common general-purpose text editors. They are likely to be the default OS text editor and users may want to use them for editing most/all files, which could include common sensitive files such as ~/.bashrc and profiles in ~/.config/firejail. Fixes netblue30#6002. Relates to netblue30#924 netblue30#941 netblue30#1154. Reported-by: @ilikenwf
kmk3
force-pushed
the
firecfg-disable-text-editors
branch
from
07ea54c
to
f1365a8
Compare
kmk3
added a commit
that referenced
this pull request
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable common general-purpose text editors.
They are likely to be the default OS text editor and users may want to
use them for editing most/all files, which could include common
sensitive files such as ~/.bashrc and profiles in ~/.config/firejail.
Fixes #6002.
Relates to #924 #941 #1154.
Reported-by: @ilikenwf