-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiles: fix misc in kmail and transmission-qt & add kontact.profile #5905
base: master
Are you sure you want to change the base?
Conversation
KMail needs sound access to play notification sounds when an email is received.
Kontact profile largely based on kmail profile with additions, kontact also uses kmail for email so it is sensible to only add "noblacklist"s since the configuration files are shared.
etc/profile-a-l/kmail.profile
Outdated
@@ -63,4 +62,7 @@ private-dev | |||
# writable-run-user is needed for signing and encrypting emails | |||
writable-run-user | |||
|
|||
# enable desktop notifications | |||
dbus-user.talk org.freedesktop.Notifications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is ignored because there is no dbus-user filter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case should the user be prompted to add both that line and dbus-user filter
to their .local?
@rusty-snake All your suggestions are now implemented, thanks again :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new profile is nearly identical to kmail.profile; it should probably be a
redirect to the latter.
See redirect_alias-profile.template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I had time for the full review.
#dbus-user.talk org.freedesktop.Notifications | ||
#dbus-user filter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#dbus-user.talk org.freedesktop.Notifications | |
#dbus-user filter | |
#dbus-user filter | |
#dbus-user.talk org.freedesktop.Notifications |
@@ -63,4 +62,8 @@ private-dev | |||
# writable-run-user is needed for signing and encrypting emails | |||
writable-run-user | |||
|
|||
# to enable desktop notifications, add these commented lines to your kmail.local file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# to enable desktop notifications, add these commented lines to your kmail.local file | |
# To harden kmail.profile, add the following lines to your kmail.local file |
noblacklist ${HOME}/.cache/kontact | ||
noblacklist ${HOME}/.config/kontactrc | ||
noblacklist ${HOME}/.config/kontact_summaryrc | ||
noblacklist ${HOME}/.local/share/kontact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never blacklisted.
# Persistent local customizations | ||
include kontact.local | ||
# Persistent global definitions | ||
include globals.local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
globals.local is included twice. Thee redirect_alias template or other redirection profiles.
@@ -15,6 +15,9 @@ private-bin transmission-qt | |||
#dbus-user.own com.transmissionbt.Transmission.* | |||
#dbus-user.talk org.freedesktop.Notifications | |||
|
|||
# System tray support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# System tray support | |
# For system tray support, add the next 2 lines to your transmission-qt.local. | |
#ignore dbus-user none | |
#dbus-user filter |
This removes "nosound" from kmail.profile to allow notification sounds, and also adds a "dbus-user.talk org.freedesktop.Notifications" to allow notifications to start.
Also adds kontact.profile based on kmail.profile, have been using it and works well.
Also edits transmission-qt.profile to allow systray, commented out as is usually the case with profiles, but better to at least let the user know that it might be necessary to add to .local if they need systray.
EDIT: if the maintainers also prefer to keep "nosound" for kmail, it might make sense to also add it to kontact.profile since I didn't add it there to start, I think it makes sense to either remove it or add a comment letting the user know that sound notifications won't work unless they "ignore nosound"