Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[management] Add MySQL Support #3108

Merged
merged 36 commits into from
Jan 6, 2025
Merged

[management] Add MySQL Support #3108

merged 36 commits into from
Jan 6, 2025

Conversation

bcmmbaga
Copy link
Contributor

Describe your changes

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

ismail0234 and others added 4 commits December 23, 2024 13:06
@ismail0234
MySQL Support (#2837)
215c904 
* Update store.go

* Update sql_store.go

* Update store.go

* Update golang-test-linux.yml

* Update store.go

* Update go.mod

* Update go.mod

* Update go.sum

* Update store.go

* Update sql_store.go

* TestContainer

* Update go.sum

* Update store.go

* TestUtil Duplicate

* dsn fix

* go mod tidy

* NETBIRD_STORE_ENGINE_MYSQL_DSN

* Skip Test

* Update test-infrastructure-files.yml

* Update test-infrastructure-files.yml

* MYSQL_ROOT_PASSWORD added

* Update test-infrastructure-files.yml

* Update store.go

* Debug + Mysql JSON Query

* swicth/case convert

* Update store.go

* Update store.go

* Debug

* MySQL Test Version Change

* Root Test

* Ignore other sql tests.

* MySQL Connection Fix

* enable other tests

* The word "key" is a reserved word in MySQL.

* Remove Debugs

* Update sql_store.go

* Added default null value for datetime.

* Added default null value for datetime.

* MySQL Hooks

* MySQL Config File

* remove default values

* test timeout change

* MySQL max lifetime change

* WithConfigFile

* disable other tests

* Update mysql.cnf

* Update golang-test-linux.yml

* Delete sql_hooks.go

* enable other tests

* test timeout change

* update packets

* Fix the Inactivity Expiration problem

* Update sql_store.go

* Update mysql.cnf

* Update sql_store.go

* Update sql_store.go

* timeout change

* MySQL Connection LifeTime Change

* TestContainers have been optimized.

* Update store_ios.go

* Update sql_store.go

* timeout fix

* fix migration (setup keys)

* Update event.go

* Add disable option for event activities.

* Revert "Update event.go"

* Update event.go

* Fix Gorm Mysql Bug

* update go-jose module

* containerd module update

* containerd downgrade

* Revert commits

* Revert "Revert commits"

This reverts commit 62b3eac.

* Revert "containerd downgrade"

This reverts commit 4e46108.

* Revert "containerd module update"

This reverts commit e8cfa87.

* Revert "update go-jose module"

This reverts commit 1fabdc7.
@bcmmbaga
Downgrade test containers to v0.31.0
f75af15 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga
Merge branch 'main' into feature/mysql-support
214b863 
# Conflicts:
#	management/server/account.go
#	management/server/store/sql_store.go
#	management/server/store/store.go
@bcmmbaga
fix merge
0daccae 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga bcmmbaga force-pushed the feature/mysql-support branch from a25e299 to 6a1db52 Compare December 24, 2024 13:51
@bcmmbaga bcmmbaga force-pushed the feature/mysql-support branch from 6a1db52 to 626b36f Compare December 24, 2024 14:03
@bcmmbaga bcmmbaga force-pushed the feature/mysql-support branch from c155d2b to 7328a0e Compare December 27, 2024 14:25
@bcmmbaga bcmmbaga force-pushed the feature/mysql-support branch from 7328a0e to 80d1bed Compare December 27, 2024 14:30
@bcmmbaga bcmmbaga force-pushed the feature/mysql-support branch from b7da985 to 1adab0d Compare December 30, 2024 15:39
@bcmmbaga bcmmbaga marked this pull request as ready for review December 30, 2024 16:10
@bcmmbaga bcmmbaga force-pushed the feature/mysql-support branch from 4c4bc16 to 525019b Compare January 2, 2025 12:49
@bcmmbaga bcmmbaga force-pushed the feature/mysql-support branch from 64fa18f to c76683a Compare January 2, 2025 14:37
@bcmmbaga bcmmbaga force-pushed the feature/mysql-support branch from 0b9d596 to 265b042 Compare January 2, 2025 16:15
@ismail0234
Copy link
Contributor

All of these commits are unnecessary. In the PR I have already opened, mysql is running without any problems. I don't understand why you send so many useless commits.

@bcmmbaga
Copy link
Contributor Author

bcmmbaga commented Jan 3, 2025

All of these commits are unnecessary. In the PR I have already opened, mysql is running without any problems. I don't understand why you send so many useless commits.

The current setup with MySQL works only when the SQL mode is not set, but with the default strict mode, it encounters issues. Some of the broken functionality includes adding new users, creating user PATs, creating new setup keys, and adding new peers. These additional commits aim to address these problems and ensure the MySQL test container runs in strict mode to verify everything works correctly and to catch any potential issues that could break MySQL support

@bcmmbaga
Fix tests
b740fef 
Signed-off-by: bcmmbaga <[email protected]>
@bcmmbaga bcmmbaga force-pushed the feature/mysql-support branch from dbe2d0f to b740fef Compare January 3, 2025 09:45
@ismail0234
Copy link
Contributor

All of these commits are unnecessary. In the PR I have already opened, mysql is running without any problems. I don't understand why you send so many useless commits.

The current setup with MySQL works only when the SQL mode is not set, but with the default strict mode, it encounters issues. Some of the broken functionality includes adding new users, creating user PATs, creating new setup keys, and adding new peers. These additional commits aim to address these problems and ensure the MySQL test container runs in strict mode to verify everything works correctly and to catch any potential issues that could break MySQL support

It should not be difficult for users to set sql mode. I have been using the mysql engine in a production environment for 1 month. I have not encountered any problems so far.

250+ onlines
600+ peers

Performance is quite good.

@bcmmbaga bcmmbaga force-pushed the feature/mysql-support branch from f517031 to b178e71 Compare January 3, 2025 15:07
@bcmmbaga bcmmbaga force-pushed the feature/mysql-support branch from da944cb to a49cccf Compare January 3, 2025 16:54
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.7% Duplication on New Code

See analysis details on SonarQube Cloud

@mlsmaycon mlsmaycon merged commit 02a3fed into main Jan 6, 2025
47 checks passed
@mlsmaycon mlsmaycon deleted the feature/mysql-support branch January 6, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlsmaycon mlsmaycon mlsmaycon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcmmbaga @ismail0234 @mlsmaycon