Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[management] enable optional zitadel configuration of a PAT #2661

Closed
wants to merge 1 commit into from

Conversation

adasauce
Copy link
Contributor

for service user via the ExtraConfig fields

Describe your changes

I'm sure this one is a little spicier of a take than my last PR to merge in some extra logging. During my struggle to get the recent zitadel working with netbird, I added the ability for netbird to just use a PAT to work around it while I investigated further.

Since the JWT and PAT both use the same mechanism to pass the token in the authorization header, the existing struct for JWTToken can be used and the authentication step short-circuited by supplying a long lasting AccessToken.

My current configuration looks somewhat like this:

    "IdpManagerConfig": {
        "ManagerType": "zitadel",
        "ClientConfig": {
           ...
        },
        "ExtraConfig": {
            "ManagementEndpoint": "https://zitadel-domain/management/v1",
            "PAT": "*****************************"
        },

As zitadel operators for more than just netbird, we have PATs for multiple different project service accounts across other orgs that integrate with it, and would prefer to use a PAT to simplify our security procedures too.

I'm not sure if this is the best end state for user experience as I rushed to implement something that worked in a fire, but figured this would be a good starting place to open the conversation.

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

Copy link

@mlsmaycon
Copy link
Collaborator

@adasauce thanks for your contribution. Can you please rebase or merge the latest changes into the fork?

@mlsmaycon
Copy link
Collaborator

mlsmaycon commented Dec 24, 2024

@adasauce it seems like there was a temporary issue with docker hub APIs. can you restart the failing tests?

@mlsmaycon
Copy link
Collaborator

@adasauce, any feedback on this? For some reason, I am unable to restart them myself. That could be a fork configuration.

@mlsmaycon mlsmaycon closed this Jan 6, 2025
@mlsmaycon
Copy link
Collaborator

closing due to no response

@adasauce
Copy link
Contributor Author

adasauce commented Jan 7, 2025

closing due to no response

Hey @mlsmaycon , sorry I'm just getting back into the swing of things in the new year and catching up. I rebased my branch if you want to re-open this PR.

I'll be available for putting a bow on this in the short term if you'd like to keep moving forward with getting this upstream. Still leveraging it in our deployment to best align with existing business processes with zitadel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants