-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-state neuron models #3069
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: ClaudiaMer <[email protected]>
Co-authored-by: ClaudiaMer <[email protected]>
Co-authored-by: ClaudiaMer <[email protected]>
Co-authored-by: ClaudiaMer <[email protected]>
Co-authored-by: ClaudiaMer <[email protected]>
Co-authored-by: ClaudiaMer <[email protected]>
Co-authored-by: ClaudiaMer <[email protected]>
Co-authored-by: ClaudiaMer <[email protected]>
Co-authored-by: ClaudiaMer <[email protected]>
Co-authored-by: ClaudiaMer <[email protected]>
Co-authored-by: ClaudiaMer <[email protected]>
Co-authored-by: ClaudiaMer <[email protected]>
Co-authored-by: ClaudiaMer <[email protected]>
Co-authored-by: ClaudiaMer <[email protected]>
Co-authored-by: ClaudiaMer <[email protected]>
Co-authored-by: ClaudiaMer <[email protected]>
Co-authored-by: ClaudiaMer <[email protected]>
Hi @jasperalbers @ClaudiaMer thanks for your contribution! In terms of documentation:
Note that we use reStructured text markup Please don't hesitate to ask if you have further questions :) |
Thanks for the information regarding the documentation! Before we start to work on this we would like to get confirmation on whether these models will be integrated into NEST or not, just to avoid unnecessary work in case they are deemed as not useful. |
Makes sense, I would suggest that the quickest way would be to join the open NEST developer meeting on Monday @ 1130 and we can add it to the agenda :) |
We decided in this week's meeting that the models should be added to NEST. I will mark this PR as a draft until we supply the necessary tests and documentation, at which point it will be ready for review. |
Pull request automatically marked stale! |
@ClaudiaMer thanks so much for adding some documentation! Could you please merge master and resolve the conflicts? For each new model contribution, we ask that an example PyNEST script is also added so users can understand a basic use case. |
This PR proposes to add multi-state neuron models used for studying infection dynamics as described in [1]. Building on the implementation of the binary neuron, these models can be in either of three states: S, I or R.
In particular, three new neuron models are added:
Their implementation closely follows the example set by the binary neuron.
If these models are deemed interesting enough to be added to the NEST simulator, we (@jasperalbers and @ClaudiaMer) would also add the corresponding documentation and tests. Here, we would be grateful for a pointer to a minimal example of what is required for both documentation and tests if that exists.
[1] https://arxiv.org/abs/2312.14851