Create ckb-error and use it as the global system error type #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@quake is assigned as the chief reviewer |
keroro520
changed the title
![nervos-bot[bot]](https://avatars.githubusercontent.com/in/22976?s=60&v=4){kind=small}
doitian
added
the
s:waiting-on-author
keroro520
force-pushed
the
ckb-error-kind
branch
from
8a5b85b to
cc6203b
Compare
keroro520
changed the title
keroro520
added
s:waiting-on-reviewers
keroro520
force-pushed
the
ckb-error-kind
branch
from
8868233 to
c7f2fcc
Compare
u2
reviewed
Sep 5, 2019
keroro520
force-pushed
the
ckb-error-kind
branch
from
9df98c8 to
029e902
Compare
u2
reviewed
Sep 5, 2019
zhangsoledad
reviewed
Sep 5, 2019
|
I oppose all TooMuch TooMany-series rename |
zhangsoledad
reviewed
Sep 5, 2019
|
I would suggest changing the error names and descriptions back to the original. And then open another issue to discuss it. What are your opinions? |
keroro520
force-pushed
the
ckb-error-kind
branch
from
dfd8ad2 to
e8885a1
Compare
u2
approved these changes
Sep 9, 2019
|
bors r=quake,u2,zhangsoledad |
bors bot
added a commit
that referenced
this pull request
Sep 9, 2019
1386: Create ckb-error and use it as the global system error type r=quake,u2,zhangsoledad a=keroro520 * Create ckb-error and use it as the global system error type * This PR is an update of #1344 based on #1344 (comment) * There are several error kinds, and the corresponding error types: * OutPoint: `util/types/src/core/error.rs` * Transaction: `verification/src/error.rs` * Script: `script/src/error.rs` * Header: `verification/src/error.rs` * Block: `verification/src/error.rs` * Internal: `error/src/internal.rs` * Dao: `util/dao/utils/src/error.rs` * Spec: `spec/src/error.rs` This PR does not cover the error types in ckb-miner, ckb-rpc and ckb-sync. Perhaps do it later. ---- NOTE: - I will remove the `NOTE: the original name is *` lines later. These lines are used to help review. Co-authored-by: keroro520 <[email protected]>
keroro520
force-pushed
the
ckb-error-kind
branch
from
e8885a1 to
57aa831
Compare
Canceled |
|
bors r=quake,u2,zhangsoledad |
bors bot
added a commit
that referenced
this pull request
Sep 9, 2019
1386: Create ckb-error and use it as the global system error type r=quake,u2,zhangsoledad a=keroro520 * Create ckb-error and use it as the global system error type * This PR is an update of #1344 based on #1344 (comment) * There are several error kinds, and the corresponding error types: * OutPoint: `util/types/src/core/error.rs` * Transaction: `verification/src/error.rs` * Script: `script/src/error.rs` * Header: `verification/src/error.rs` * Block: `verification/src/error.rs` * Internal: `error/src/internal.rs` * Dao: `util/dao/utils/src/error.rs` * Spec: `spec/src/error.rs` This PR does not cover the error types in ckb-miner, ckb-rpc and ckb-sync. Perhaps do it later. ---- NOTE: - I will remove the `NOTE: the original name is *` lines later. These lines are used to help review. Co-authored-by: keroro520 <[email protected]>
|
bors r=quake,u2,zhangsoledad |
bors bot
added a commit
that referenced
this pull request
Sep 9, 2019
1386: Create ckb-error and use it as the global system error type r=quake,u2,zhangsoledad a=keroro520 * Create ckb-error and use it as the global system error type * This PR is an update of #1344 based on #1344 (comment) * There are several error kinds, and the corresponding error types: * OutPoint: `util/types/src/core/error.rs` * Transaction: `verification/src/error.rs` * Script: `script/src/error.rs` * Header: `verification/src/error.rs` * Block: `verification/src/error.rs` * Internal: `error/src/internal.rs` * Dao: `util/dao/utils/src/error.rs` * Spec: `spec/src/error.rs` This PR does not cover the error types in ckb-miner, ckb-rpc and ckb-sync. Perhaps do it later. ---- NOTE: - I will remove the `NOTE: the original name is *` lines later. These lines are used to help review. Co-authored-by: keroro520 <[email protected]>
zhangsoledad
removed
the
s:waiting-on-author
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create ckb-error and use it as the global system error type
This PR is an update of [HOLD] feat: create ckb-error #1344 based on [HOLD] feat: create ckb-error #1344 (comment)
There are several error kinds, and the corresponding error types:
util/types/src/core/error.rsverification/src/error.rsscript/src/error.rsverification/src/error.rsverification/src/error.rserror/src/internal.rsutil/dao/utils/src/error.rsspec/src/error.rsThis PR does not cover the error types in ckb-miner, ckb-rpc and ckb-sync. Perhaps do it later.
NOTE:
NOTE: the original name is *lines later. These lines are used to help review.