Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UpdateRemotePlugins not finding specs on windows #565

Merged
merged 3 commits into from
Apr 14, 2024
Merged

fix: UpdateRemotePlugins not finding specs on windows #565

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4cb2499
fix: UpdateRemotePlugins not finding specs on windows
tanj Apr 13, 2024
a2bc40e
fix: change to pathlib for resolving paths so we can use posix paths
tanj Apr 13, 2024
68250cb
fix: take a hybrid approach to restore tests
tanj Apr 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pynvim/plugin/host.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import logging
import os
import os.path
import pathlib
import re
import sys
from functools import partial
Expand Down Expand Up @@ -173,7 +174,7 @@ def _load(self, plugins: Sequence[str]) -> None:
# self.nvim.err_write("host init _load\n", async_=True)
has_script = False
for path in plugins:
path = os.path.normpath(path) # normalize path
path = pathlib.Path(os.path.normpath(path)).as_posix() # normalize path
err = None
if path in self._loaded:
warn('{} is already loaded'.format(path))
Expand Down Expand Up @@ -276,6 +277,7 @@ def _copy_attributes(self, fn, fn2):

def _on_specs_request(self, path):
path = decode_if_bytes(path)
path = pathlib.Path(os.path.normpath(path)).as_posix() # normalize path
if path in self._load_errors:
self.nvim.out_write(self._load_errors[path] + '\n')
return self._specs.get(path, 0)
Expand Down
Loading