test: always use the same exact python executable regardless of $PATH #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wookayin
force-pushed
the
fix-test-path
branch
from
9518374 to
56277b8
Compare
wookayin
changed the title
wookayin
force-pushed
the
fix-test-path
branch
2 times, most recently
from
51a6668 to
9fdc7a0
Compare
Problem:
The embedded neovim fixture instance for testing picks up `python3`
on the `$PATH`. This can be different from the current python.
(Example)
$ which python3
/usr/local/bin/python3
$ which python3.11
$HOME/.pyenvs/versions/3.11.5/bin/python3.11
$ python3.11 -m pytest
then neovim will have `/usr/local/bin/python3` as the python3 host
(however should be `python3.11`), so the behavior of `:python` and
the `pynvim` module especially when it has local changes during
development) can be different.
Solution:
The embedded nvim instance should always pin `g:python3_host_prog` to
`sys.executable`.
wookayin
force-pushed
the
fix-test-path
branch
from
9fdc7a0 to
75426db
Compare
wookayin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The embedded neovim fixture instance for testing picks up
python3on the
$PATH. This can be different from the current python.(Example)
then neovim will have
/usr/local/bin/python3as the python3 host,so the behavior of
:python(andpynvimespecially when it has localchanges during development) can be different.
Solution:
The embedded nvim instance should always pin
g:python3_host_progtosys.executable.