fix: invalid CLI use in scripts/{enable,disable}_log_statements.sh #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wookayin
changed the title
- `find -name` => `find . -name` - `xargs -i` => `xargs -I` (or can be replaced by the for loop) - Use bash for loop instead of xargs to abort early when erorr happens - Have one whitespace after `#` in the comments to conform with the standard python code style
justinmk
reviewed
Nov 13, 2023
| find -name '*.py' | xargs -i{} ../scripts/logging_statement_modifier.py {} | ||
| for f in $(find . -name '*.py'); do | ||
| echo "Processing: $f" | ||
| ../scripts/logging_statement_modifier.py "$f" |
There was a problem hiding this comment.
For reference: this script is a hack to workaround performance issues: #250
Ideally we would avoid costly logging in a more architectural way rather than a build-time hack.
There was a problem hiding this comment.
Right, fully agreed; this seems really hacky. Just quick-fixing the shell script for now because it didn't work in macOS :)
justinmk
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find -name=>find . -namexargs -i=>xargs -I(or can be replaced by the for loop)#in the comments to conform with thestandard python code style
(should the commit message be prefixed with
packaging:orfix:?)