Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for attaching through socket, tcp, and stdio #544

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

wookayin
Copy link
Member

No description provided.

@wookayin
Copy link
Member Author

on Windows: should we skip or xfail some tests?

  • stdio fails. although implemented in _connect_stdio, it appears to have been broken for a while.
  • socket also fails. Seems we need to create socket files in a Windows-specific manner, but haven't figured out yet.

@justinmk
Copy link
Member

justinmk commented Dec 5, 2023

on Windows: should we skip or xfail some tests?

xfail seems better, it will let us know when behavior is fixed.

@wookayin
Copy link
Member Author

wookayin commented Dec 6, 2023

Yes I agree. I rebased the tests (with xfail). I don't have any working windows machines for development so it's quite difficult for me to fix the failing tests on windows. But will try to figure out sometime soon.

On windows somehow socket and stdio tests are failing, which should be
fixed sometimes later.
@justinmk justinmk merged commit e74a7f6 into neovim:master Dec 6, 2023
19 checks passed
@wookayin wookayin deleted the test-attach branch December 10, 2023 10:24
@wookayin wookayin added the test label Jan 14, 2024
jamessan added a commit that referenced this pull request Nov 3, 2024
Changes since 0.5.0:

- 4813ce6 fix(tests): failing tests on python3.13 about stacktrace messages #578
- 9391eff docs: avoid deprecated $NVIM_LISTEN_ADDRESS env var #575
- 9fc77f0 fix(tests): remove reference to pytest-runner #573
- a855fa3 fix: deprecated alias of logger.warn #569
- cc45f5b fix(tests): broadcast test fails #570
- 4d65226 fix(ci): macOS CI fails with "Unrecognized archive format"
- d6dc8cf fix: UpdateRemotePlugins not finding specs on Windows #565
- 9f3e010 Revert "fix: vim.eval('v:true') should return python bool" #562
- f9d839f fix(tests): "provider#python3#Prog" was removed upstream #563
- 5f989df refactor: remove the use of forward references #558
- c4197f1 fix(ci): failing readthedocs build #554
- da0970e ci: fix failing readthedocs build
- 7a84048 fix(ci): failing readthedocs build #553
- e74a7f6 test: attaching via socket, tcp, stdio #544
- 17fbcbc fix: prevent closed pipe errors on closing asyncio transport resources
- 7f60f72 refactor: improve typing
- 3f5f532 refactor: separate asyncio Protocol from AsyncioEventLoop
- 2059684 refactor: use async coroutine and add debugging statements
- be5810b refactor: expose event loop as a property rather than a field
- a1347ee refactor!: completely wipe out pyuv
@jamessan jamessan mentioned this pull request Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants