feat: allow list of client ids or config names in LspRestart and LspStop

[guilhas07]

Problems:

• :LspStop doesn't support list of client ids or config names.
• :LspRestart doesn't support config names although supports list of client ids
• Command completion uses ids and names, not allowing the user to hit enter immediately after
  finding the desired server

Solution:

• Unify LspStop and LspRestart implementation supporting lists of client ids and
  config names
• Command completion only returns config names
• Modify docs

[glepnir]

why remove id ? if there are multiple servers which does not support workspace folders, it will be difficult to distinguish which one want to stop

[guilhas07]

Are saying that its possible to receive multiple entries like:

• 1 lua_ls
• 2 lua_ls

If that is the case than I will revert this.

Is there a way to show the completion with the id and name but on complete only pass the id so the user
only needs to hit enter?

[glepnir]

revert . if you want complete with input id need imporve current custom complete and split cmdline content to get id then complete with server name

[guilhas07]

When testing I found that lua_ls didn't close on first LspStop or LspRestart . Should LspRestart use force=true ?

nvim-lspconfig/plugin/lspconfig.lua

Line 104 in b55037d

client.stop()

[guilhas07]

Is this enough to match all valid config names ?

[glepnir]

nope.. some server file name without underline..Because there has been no standard in the past of the server file name, the naming has become arbitrary. It is best to use xx_ls. This can be refactored later.

[guilhas07]

But this matches server names without underscore too so that is not a problem. I meant if there are characters that I'm currently not matching that should be included.

[guilhas07]

Supporting lists is out of scope. These commands are meant for interactive use, and the use-case for passing multiple args simulatenously is uncommon, thus not worth the code complexity (nor the extra documentation). For programmatic use the api should be used.

With these changes both LspRestart and LspStop use the same parsing function, simplifying the LspStop code (went from 47 to 25 loc), and adding the possibility to use config name for LspRestart and error logging. Overall the diff is around the same loc.

 plugin/lspconfig.lua | 93 ++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------------
 1 file changed, 48 insertions(+), 45 deletions(-)

In terms of added complexity in the parsing function, only error logging and substitution from config_name to client id was added, which in my opinion its easy to follow (although I can add more comments if its necessary).

Fixing that is welcome, and should be the focus of this PR.

This was what motivate me to also add the list, because if it works correctly it would be very fast to autocomplete two Lsp
servers. Also, the LspRestart command already supported it (though not documented).

Do you have any pointers how to fix it ? I presume that I can insert some logic when accepting a completion so it uses the id.

Edit:
I think this is not possible:

I presume that I can insert some logic when accepting a completion so it uses the id.

I'm still confused on what the problem would be if only the config name is used in the completion, given that config_name is already supported and in multiple code paths it seems to be assumed that config_name is enough to identify the server. Example:

nvim-lspconfig/plugin/lspconfig.lua

Lines 105 to 107 in b55037d

	if vim.tbl_count(client.attached_buffers) > 0 then
	detach_clients[client.name] = { client, lsp.get_buffers_by_client_id(client.id) }
	end

[justinmk]

LGTM, let's try it. Hoping @guilhas07 will followup on any bugs :)

[guilhas07]

LGTM, let's try it. Hoping @guilhas07 will followup on any bugs :)

🫡