Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(eslint): use vim.lsp.buf.code_action to implement :EslintFixAll #3190

Closed
wants to merge 1 commit into from

Conversation

icholy
Copy link
Contributor

@icholy icholy commented Jun 3, 2024

The lsp.util.buf_versions table is deprecated and should not be used anymore. neovim/neovim#28943. Simply switching to using vim.b[bufnr].changedtick is also problematic: neovim/neovim#29163

@icholy icholy requested a review from glepnir as a code owner June 3, 2024 21:46
@icholy icholy force-pushed the eslint-use-code-action branch 2 times, most recently from 991a4a1 to 5082a11 Compare June 3, 2024 21:50
@icholy icholy marked this pull request as draft June 3, 2024 22:26
@icholy
Copy link
Contributor Author

icholy commented Jun 3, 2024

This doesn't have the same behaviour because code_action auto-fills the context.diagnostics value with the current line's diagnostics.

@glepnir
Copy link
Member

glepnir commented Jun 6, 2024

seems like those prs revert. so closed.

@glepnir glepnir closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants