Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove outdated jdtls progress message handler (#2897) #2899

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

s1n7ax
Copy link
Contributor

@s1n7ax s1n7ax commented Nov 16, 2023

progress message

before
screenshot 23-11-16 22:09:33

After
screenshot 23-11-16 22:19:08

@s1n7ax s1n7ax requested a review from glepnir as a code owner November 16, 2023 17:12
Copy link
Contributor

Do not change server_configurations.md directly. Edit the lua source file instead. See https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md#generating-docs

@s1n7ax
Copy link
Contributor Author

s1n7ax commented Nov 16, 2023

May be that screenshots are misleading. in the bottom right, noice.nvim displays the progress status by overriding vim.lsp.handlers['$/progress']. Before, jdtls had defined a handler withing the config so it never reached noice.nvim. nil in the first screenshot was printed by the jdtls config $/progress handler.

@justinmk justinmk merged commit 4834708 into neovim:master Nov 17, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants