fix(lspconfig): updating csharp-ls to look for sln when in a project structure #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joro550
changed the title
glepnir
reviewed
Sep 30, 2023
|
@glepnir seems that suggestion had failed the lint 😅 |
dundargoc
force-pushed
the
fix/cs-root-directory
branch
from
0175134
to
dbf9bac
Compare
dundargoc
force-pushed
the
fix/cs-root-directory
branch
from
dbf9bac
to
667ea80
Compare
glepnir
reviewed
Oct 8, 2023
| root_dir = function(fname) | ||
| return util.root_pattern '*.sln'(fname) | ||
| or util.root_pattern('*.csproj', '*.fsproj', '.git')(fname) | ||
| or util.root_pattern '*.fsproj'(fname) |
|
@joro550 I think your most recent commit message is failing the commit linter😅 I had the exact same issue and was about to open a PR to push my fix before I saw this, so I can do that if you don't have time |
|
@rudiejd if you have time to invest please do it 😄 I haven't had time to fix this recently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an issue when loading a project in the lsp that it wasn't detecting the sln - it was only detecting the current csproj file