Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix types of AsyncWindow/Buffer/Tabpage #265

Merged
merged 1 commit into from
Dec 3, 2023
Merged

fix: fix types of AsyncWindow/Buffer/Tabpage #265

merged 1 commit into from
Dec 3, 2023

Conversation

xiyaowong
Copy link
Contributor

@xiyaowong xiyaowong commented Dec 2, 2023 •
edited
Loading

Wrong type but no error
image

Correct type but has an error
image

@xiyaowong xiyaowong changed the title fix(types): add Promisify type to neovim APIs fix: fix types of AsyncWindow/Buffer/Tabpage Dec 2, 2023
justinmk
justinmk approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@justinmk justinmk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We really need to add more linting (eslint) to this project. Also looking at https://github.com/sindresorhus/eslint-plugin-unicorn

@justinmk justinmk merged commit 6020a11 into neovim:master Dec 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmk justinmk justinmk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiyaowong @justinmk