Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(:set): clear the message grid after showing an option #28594

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(:set): clear the message grid after showing an option #28594

wants to merge 2 commits into from

Conversation

Sam-programs
Copy link
Contributor

Fixes #28593

@zeertzjq zeertzjq added the messages UI messages, log messages label May 1, 2024
@zeertzjq
Copy link
Member

zeertzjq commented May 1, 2024 •
edited

I think the correct solution is to use something else instead of the gotocmdline() in do_one_set_option() when ext_cmdline (or ext_messages) is active.

@zeertzjq
Copy link
Member

zeertzjq commented May 2, 2024

Or maybe the change should be in gotocmdline(), making it do something different when ext_cmdline or ext_messages is active and clr is true. That may fix #11558 as well.

@Sam-programs
refactor: clear messages with msg_ext_clear
2cd751d 
(I initially thought `msg_start()` clears them with `msg_ext_ui_flush()`)
@zeertzjq zeertzjq requested a review from bfredl May 2, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfredl bfredl Awaiting requested review from bfredl

Assignees
No one assigned
Labels
messages UI messages, log messages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

:set doesn't clear old messages with ext_cmdline
2 participants
@Sam-programs @zeertzjq