-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a subproject with a JUnit session listener #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technici4n
reviewed
Dec 15, 2023
loader/src/main/java/net/neoforged/fml/loading/targets/JUnitDevLaunchTarget.java
Show resolved
Hide resolved
loader/src/main/java/net/neoforged/fml/loading/targets/JUnitDevLaunchTarget.java
Outdated
Show resolved
Hide resolved
loader/src/main/java/net/neoforged/fml/loading/targets/JUnitUserDevLaunchTarget.java
Outdated
Show resolved
Hide resolved
Outside of some documentation as to what the components do, this is good from my end. |
shartte
requested changes
Jan 20, 2024
shartte
previously approved these changes
Jan 20, 2024
Technici4n
reviewed
Jan 23, 2024
Technici4n
reviewed
Jan 23, 2024
junit/src/main/resources/META-INF/services/org.junit.platform.launcher.LauncherSessionListener
Show resolved
Hide resolved
Technici4n
reviewed
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also want to see the NeoForge PR using this. ;)
In reality it will almost always not be on module path
Technici4n ***@***.***> schrieb am Di., 23. Jan. 2024, 14:53:
… ***@***.**** commented on this pull request.
------------------------------
In
junit/src/main/resources/META-INF/services/org.junit.platform.launcher.LauncherSessionListener
<#54 (comment)>
:
> @@ -0,0 +1 @@
+net.neoforged.fml.junit.JUnitService
Any reason to specify the services both in the module-info and in
META-INF? Do we expect users to launch this outside of the module path?
—
Reply to this email directly, view it on GitHub
<#54 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJT6V2GBNKB2DKDWQJDUITYP66FLAVCNFSM6AAAAABAW3XOEKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMZYHA2DSMJWGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Last commit published: 8a40ebc2d39104fce7bbc0a0b510bfef191af0a4. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #54' // https://github.com/neoforged/FancyModLoader/pull/54
url 'https://prmaven.neoforged.net/FancyModLoader/pr54'
content {
includeModule('net.neoforged.fancymodloader', 'earlydisplay')
includeModule('net.neoforged.fancymodloader', 'junit-fml')
includeModule('net.neoforged.fancymodloader', 'loader')
}
}
} |
marchermans
approved these changes
May 18, 2024
marchermans
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will allow running JUnits in a bootstrapped Minecraft environment.