feat: Clean up mixed SQL/Cypher queries generated by Spark. [translator] #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new translator implementation, that by default is always running before the default implementation. It will check if a query looks like something that Spark did. If this is the case, the idea is to check whether the inner query is a already a cypher query. If that’s the case, no further translation will be attempted.
|
Added you @fbiville for visibility. Let's merge this and evolve as we / you folks go. I think this might be quite useful in the future.
|
loveleif
reviewed
Jan 16, 2025
...er/src/main/java/org/neo4j/jdbc/translator/sparkcleaner/SparkSubqueryCleaningTranslator.java
Outdated
Show resolved
Hide resolved
loveleif
reviewed
Jan 16, 2025
...er/src/main/java/org/neo4j/jdbc/translator/sparkcleaner/SparkSubqueryCleaningTranslator.java
Show resolved
Hide resolved
Signed-off-by: Michael Simons <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new translator implementation, that by default is always running before the default implementation. It will check if a query looks like something that Spark did.
If this is the case, the idea is to check whether the inner query is a already a cypher query. If that’s the case, no further translation will be attempted.