Add documentation for dryrun parameter
#2311
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `dryrun` paramater's documentation is unhelpful (`dryrun mode`). In the absense of proper documentation, [this definition from a comment on this topic](nektos#268 (comment)) should be used. Fixes: nektos#268
cplee
approved these changes
May 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2311 +/- ##
===========================================
+ Coverage 61.56% 76.49% +14.92%
===========================================
Files 53 59 +6
Lines 9002 7504 -1498
===========================================
+ Hits 5542 5740 +198
+ Misses 3020 1241 -1779
- Partials 440 523 +83 ☔ View full report in Codecov by Sentry. |
|
@JackPGreen this pull request has failed checks 🛠 |
I can't see anything in the logs that jumps out as a failure. Cynically I don't understand test failures for such a trivial change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dryrunparamater's documentation is unhelpful (dryrun mode).In the absense of proper documentation, this definition from a comment on this topic should be used.
Fixes: #268