don't spam duplicate warnings in github_context #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to go-git/go-git#530, act will spam the console/log with a billion warnings like this: WARN[0000] unable to get git repo: branch config: invalid merge when a GitHub PR branch is checked out.
chris-laplante
force-pushed
the
cpl/github_context_warnings
branch
from
e471958
to
200db77
Compare
Comment on lines
+13
to
+17
| var ( | ||
| loggedWarnings = make(map[string]bool) | ||
| mu sync.Mutex | ||
| ) | ||
|
|
There was a problem hiding this comment.
I don't like doing this kind of stuff with globals. Caching the git stuff would be better.
There was a problem hiding this comment.
OK, I'll try to find some time to work on adding the caching.
|
@chris-laplante this pull request is now in conflict 😩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to go-git/go-git#530, act will spam the console/log with a billion warnings like this:
WARN[0000] unable to get git repo: branch config: invalid merge
when a GitHub PR branch is checked out.