Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fail to find local subworkflow of remote workflow #1876

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

wildsheepz
Copy link
Contributor

Proposing a fix for #1875 . I included a new unit test to verify the issue.

@wildsheepz wildsheepz requested a review from a team as a code owner June 22, 2023 11:07
@mergify
Copy link
Contributor

mergify bot commented Jun 22, 2023

@wildsheepz this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Attention: 1019 lines in your changes are missing coverage. Please review.

Comparison is base (4989f44) 61.22% compared to head (27e3f82) 60.71%.
Report is 299 commits behind head on master.

Files Patch % Lines
pkg/artifactcache/handler.go 65.46% 102 Missing and 42 partials ⚠️
pkg/runner/run_context.go 73.37% 75 Missing and 19 partials ⚠️
pkg/runner/expression.go 55.17% 66 Missing and 12 partials ⚠️
pkg/runner/action_cache.go 50.74% 49 Missing and 17 partials ⚠️
pkg/container/docker_run.go 1.51% 64 Missing and 1 partial ⚠️
pkg/model/planner.go 31.76% 54 Missing and 4 partials ⚠️
pkg/container/docker_network.go 0.00% 56 Missing ⚠️
pkg/runner/reusable_workflow.go 51.88% 44 Missing and 7 partials ⚠️
pkg/model/workflow.go 43.37% 40 Missing and 7 partials ⚠️
pkg/common/outbound_ip.go 0.00% 44 Missing ⚠️
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1876      +/-   ##
==========================================
- Coverage   61.22%   60.71%   -0.52%     
==========================================
  Files          46       53       +7     
  Lines        7141     8972    +1831     
==========================================
+ Hits         4372     5447    +1075     
- Misses       2462     3084     +622     
- Partials      307      441     +134     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify
Copy link
Contributor

mergify bot commented Jul 10, 2023

@wildsheepz this pull request has failed checks 🛠

@mergify
Copy link
Contributor

mergify bot commented Jul 11, 2023

@wildsheepz this pull request has failed checks 🛠

@mergify
Copy link
Contributor

mergify bot commented Jul 11, 2023

@wildsheepz this pull request has failed checks 🛠

Copy link
Contributor

github-actions bot commented Jan 9, 2024

PR is stale and will be closed in 14 days unless there is new activity

@github-actions github-actions bot added stale and removed stale labels Jan 9, 2024
Copy link
Contributor

mergify bot commented Jan 19, 2024

@wildsheepz this pull request has failed checks 🛠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-work Extra attention is needed size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants