Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Number.isNaN instead of global isNaN. #2941

Merged
merged 7 commits into from
May 27, 2024
Merged

Use Number.isNaN instead of global isNaN. #2941

merged 7 commits into from
May 27, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented May 16, 2024

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ee4fdfd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KenAJoh KenAJoh enabled auto-merge (squash) May 16, 2024 16:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited
Loading

Storybook demo

e7002c562 | 81 komponenter | 182 stories

HalvorHaugan
HalvorHaugan previously approved these changes May 23, 2024
View reviewed changes
JulianNymark
JulianNymark previously approved these changes May 24, 2024
View reviewed changes
@navikt/core/react/src/date/utils/check-dates.ts Outdated Show resolved Hide resolved
@KenAJoh KenAJoh dismissed stale reviews from JulianNymark and HalvorHaugan via e84b328 May 27, 2024 07:17
@KenAJoh
Copy link
Collaborator Author

KenAJoh commented May 27, 2024

true! could update the function paramemter type here :) (it's already of type day: Date meaning all calls to this function should pass in a valid Date (and it'll probably always be truthy? I haven't actually deep dived into Date 😅 )

Updated to day?: Date 👍

@KenAJoh KenAJoh merged commit f05615d into main May 27, 2024
3 checks passed
@KenAJoh KenAJoh deleted the noGlobalIsNan branch May 27, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalvorHaugan HalvorHaugan HalvorHaugan approved these changes

@JulianNymark JulianNymark JulianNymark left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KenAJoh @JulianNymark @HalvorHaugan