-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Primitives] BasePrimitive #2842
Conversation
|
Storybook demoEndringer til review: 242561bf69 | 85 komponenter | 160 stories |
/** | ||
* CSS `overflow` | ||
*/ | ||
overflow?: ResponsiveProp<"visible" | "hidden" | "clip" | "scroll" | "auto">; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should revisit the JSDOC later. It's a little inconsistent that we write about the object option only on some of the props, when it applies to all of them. Maybe the JSDOC for each prop should be really simple and short, with a link to some place with more details 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good idea, think ResponsiveProp
and in general the Primitives concept deserves a documentation-page under /grunnleggende when its implemented and tested. Can link to that documentation then 👍
Co-authored-by: Halvor Haugan <[email protected]>
Co-authored-by: Halvor Haugan <[email protected]>
Co-authored-by: Halvor Haugan <[email protected]>
Co-authored-by: Halvor Haugan <[email protected]>
Description
Inspirert av Radix Themes tilbyr de et sett med "base"-props for alle Primitivene sine.
BasePrimitive
-komponenten er en forsøk på å løse det samme, og vil være en intern komponent som gjenbrukes av de andre.Hvordan tiltenkt bruk er:
Siden
BasePrimtive
er en "Slot"-komponent vil det ikke føre til ekstra html-noder.Usikker på om denne bør extende alle komponentene, gir f.eks kanskje ikke mening på show/hide og bleed(?)
WIP tiltenkte props denne base-komponenten tilbyr
Alt er oppe i luften her, så alt av innspill eller idèer er supert!