Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate (Chore) Add presentation logic to a Presenter class" #1109

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dragon-dxw
Copy link
Collaborator

Reverts #1108
Reinstates Reverts #1105

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (87aba5f) 95.47% compared to head (1331fad) 94.90%.

Files Patch % Lines
judgments/presenters/document_presenter.py 92.72% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1109      +/-   ##
==========================================
- Coverage   95.47%   94.90%   -0.57%     
==========================================
  Files          43       45       +2     
  Lines        1700     1787      +87     
  Branches      278      293      +15     
==========================================
+ Hits         1623     1696      +73     
- Misses         57       69      +12     
- Partials       20       22       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dragon-dxw dragon-dxw force-pushed the revert-1108-revert-1105-chore/presentation-logic branch from 702f0ff to 2da5fdd Compare February 21, 2024 17:36
@dragon-dxw
Copy link
Collaborator Author

dragon-dxw commented Feb 21, 2024

There's nothing like linked_doc_url on the Document class, but there is a function in judgments/utils.py.

The Judgment / PressSummary classes should have access to that function.

And it needs tests.

The commit for making the methods callable at all is ugly and I don't like it.

@dragon-dxw dragon-dxw marked this pull request as draft February 22, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant