DR2-1982 Remove mockito from rotate password #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techncl
reviewed
Nov 13, 2024
| new Lambda().handler(rotationEvent, config, dependencies).unsafeRunSync() | ||
|
|
||
| verify(userClient, times(1)).testNewPassword() | ||
| res.left.value.getMessage should equal("Password test failed") | ||
| } | ||
|
|
||
| "handler finishSecret" should "return an error if the pending secret has no version" in { |
There was a problem hiding this comment.
This test doesn't return an error
There was a problem hiding this comment.
Oh yeah, copy and paste error I think. I've changed it.
| new Lambda().handler(rotationEvent, config, dependencies).unsafeRunSync() | ||
|
|
||
| verify(secretsManagerClient, times(0)).putSecretValue(any[String], any[Stage], any[Option[String]])(using any[Encoder[String]]) | ||
| secretResult.versionToStage.size should equal(1) | ||
| } | ||
|
|
||
| "handler createSecret" should "putSecretValue if a Pending value does not already exist" in { |
There was a problem hiding this comment.
I know you didn't do this in this PR, but should this be "calls putSecretValue"?
There was a problem hiding this comment.
I don't think so because we're not checking the method is called. It is a bit odd the way it is though so I've gone with "create the secret value if a Pending value does not already exist"
| new Lambda().handler(rotationEvent, config, dependencies).unsafeRunSync() | ||
|
|
||
| verify(secretsManagerClient, times(0)).putSecretValue(any[String], any[Stage], any[Option[String]])(using any[Encoder[String]]) | ||
| secretResult.versionToStage.size should equal(1) |
There was a problem hiding this comment.
Is it worth checking the password is still the same/the expected one?
There was a problem hiding this comment.
It's slightly superfluous but one extra line doesn't hurt. I've added it in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs nationalarchives/da-aws-clients#330 before the tests will pass