Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize mOriginUs lazily #167

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jumperson
Copy link
Contributor

#138
Library transcode video with artifacts. Link to video

I have same issue.

I checked the diffs for v0.9.1 and v0.10.0 and found that there was an issue at 997de45 .

After proceeding with the verification, it seems that some terminals have side effects with mExtractor.selectTrack(i) and mExtractor.unselectTrack(i) .

Therefore, I changed the timing to set mOriginUs .

@jumperson
Copy link
Contributor Author

@natario1
Thank you for developing a great library.
I would appreciate it if you could review the fix.

@natario1 natario1 changed the title fix artifacts video Initialize mOriginUs lazily Mar 12, 2022
@tudormarze
Copy link

Hello @jumperson I have tried the changes from the fork and transcoding a video with the buffer.hasRemaining issue, it seems to get in an infinite loop.

In my case any video downloaded from TikTok produces that issue on an Android 12 device.

@jumperson
Copy link
Contributor Author

jumperson commented Aug 31, 2022

Hello @tudormarze.
Can you try taking in both #158 and #167 ?
Or the main branch of StudistCorporation/Transcoder has both #158 and #167, so try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants