Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Dumping and Loading Checkpoints During Run Mode #1727

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

Mrockwell2
Copy link
Contributor

@Mrockwell2 Mrockwell2 commented May 31, 2024

Solves issue #1461 while also allowing for scheduling checkpoints at future times and using trick.add_read to load checkpoints at specific times.

@Mrockwell2 Mrockwell2 linked an issue May 31, 2024 that may be closed by this pull request
@Mrockwell2 Mrockwell2 changed the title edit checkpoint at time Prevent Dumping and Loading Checkpoints During Run Mode May 31, 2024
@Mrockwell2
Copy link
Contributor Author

Just found that this might break Master-Slave. The Slave can mimic the Master automatically when it dumps or loads a checkpoint. Going to have to look at how the Master dumps and loads checkpoints. I'm also going to create an issue that MasterSlave has no tests.

@coveralls
Copy link

Coverage Status

coverage: 56.241% (+0.4%) from 55.827%
when pulling 50dc60e on Mrockwell2:1461-edit-checkpoint-at-time
into 37e273a on nasa:master.

@coveralls
Copy link

Coverage Status

coverage: 56.25% (+0.4%) from 55.827%
when pulling 50dc60e on Mrockwell2:1461-edit-checkpoint-at-time
into 37e273a on nasa:master.

@coveralls
Copy link

Coverage Status

coverage: 56.241% (+0.4%) from 55.827%
when pulling 7821695 on Mrockwell2:1461-edit-checkpoint-at-time
into 37e273a on nasa:master.

@coveralls
Copy link

Coverage Status

coverage: 56.245% (+0.4%) from 55.827%
when pulling 0926010 on Mrockwell2:1461-edit-checkpoint-at-time
into 37e273a on nasa:master.

@coveralls
Copy link

Coverage Status

coverage: 56.3% (+0.4%) from 55.891%
when pulling cebc83f on Mrockwell2:1461-edit-checkpoint-at-time
into 92b0168 on nasa:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only allow dumping and loading checkpoints in freeze mode
2 participants