Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TV VariableTable max precision column option #1670

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

yusufcananar
Copy link

View Dropdown menu has Max Precision option which is not selected by default.
If user selects this option Variable Table will show the precision column that has the following features:

  • TV Variable Table precision column added to change significant figures after dot(.).
  • It only applies for TVDouble and TVFloat type of variables, any other format only shows "--".
  • Every variable precision is "--" by default. Until selection, variable shows all figures it has.
  • The feature is a generic solution to change fractional part precision [1-15].

This feature is related to #1642
I find practical to use a comboBox for precision since there can only be limited number of significance.

Example images of the feature;
trickTVMaxPrec
tvMaxPrecClosed

@sharmeye
Copy link
Contributor

Thank you for the PR. We'll pull this ourselves and test here in our development environment for a bit, to make sure it flows with our established user interface experience and to determine if there are any lurking bugs to squash. If we feel like it's a good fit we'd be happy to merge into our codebase and give you due credit for your contribution.

@yusufcananar
Copy link
Author

Is there any progress on this PR? @sharmeye

@dbankieris
Copy link
Contributor

Although I don't actively develop Trick anymore, I stumbled across this PR today, and, as the original Trick View author, was compelled to offer some feedback:

  1. Column visibility is already controlled via a widget in the top-right corner of the table. I do not recommend adding another method, despite Sean's comment. You could still start with the precision column hidden, I think.
  2. precision is meaningless for all but TVFloat and TVDouble, yet it has been added to every TV type. A better design would avoid what is essentially dead code.
  3. Setting precision might be a better feature for the Trick Variable Server rather than Trick View. Then, all Variable Server clients could benefit from it.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants