-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to lock object sub-tree and fix object locking bugs #7855
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7855 +/- ##
==========================================
+ Coverage 57.16% 57.41% +0.24%
==========================================
Files 676 676
Lines 27326 27350 +24
Branches 2673 2684 +11
==========================================
+ Hits 15622 15704 +82
+ Misses 11368 11309 -59
- Partials 336 337 +1
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
… Default to environment variables for couch config. Simplify batching mechanism to make it synchronouse
d9a72d7
to
fc8355f
Compare
fc8355f
to
b57c8b5
Compare
@charlesh88 When set by a script the lock button gets an additional css class
|
This is just pending some UI changes from @charlesh88 |
Notes on the bookmarklet:
|
startObjectKeystring: { | ||
type: 'string', | ||
short: 'o', | ||
default: 'mine' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should error out instead. this should be required
} | ||
}) | ||
.catch((error) => { | ||
console.log(`Error ${error}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.error
?
Closes #7877
Describe your changes:
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist