Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPP v2.3.0a1 #3066

Open
wants to merge 264 commits into
base: devel
Choose a base branch
from
Open

FPP v2.3.0a1 #3066

wants to merge 264 commits into from

Conversation

bocchino
Copy link
Collaborator

@bocchino bocchino commented Dec 10, 2024

This PR integrates FPP v2.3.0a1. It also makes the following changes to F Prime:

  1. In docs, add documentation for state machines.
  2. In FppTest, add tests for covering FPP state machines and related code generation.
  3. Improve const correctness in the framework.
  4. Update models to escape new keywords with $ as necessary.

Reviewing Notes

Notes and status from the in-person review on 11/20/24 are here: nasa/fpp#508 (comment).

To review code coverage on the tests, you can run fprime-util check --coverage --all-sources in the following directories:

FppTest/state_machine/internal/initial
FppTest/state_machine/internal/state
FppTest/state_machine/internal/coverage
FppTest/state_machine/internal_instance/initial
FppTest/state_machine/internal_instance/state
FppTest/state_machine/internal_instance/coverage

Code coverage is around 90-100% except in fprime/FppTest/state_machine/internal_instance/initial, where the coverage of the auto-generated component code is about 40%. This is because of the modular test design: these tests don't send signals to the state machines; only state machine initialization is tested. The code for sending signals is exercised in the other test suites.

Fw/Port/PortBase.cpp Dismissed Show dismissed Hide dismissed
Svc/SystemResources/SystemResources.hpp Dismissed Show dismissed Hide dismissed
Fw/Port/PortBase.cpp Dismissed Show dismissed Hide dismissed
This directory no longer exists in fprime/devel
@bocchino bocchino requested a review from LeStarch December 12, 2024 01:15
@bocchino bocchino marked this pull request as ready for review December 12, 2024 01:15
@bocchino bocchino requested a review from thomas-bc December 12, 2024 01:15
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the structure of FppTest and reviewed the files outside of FppTest. Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants