-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FPP v2.3.0a1 #3066
Open
bocchino
wants to merge
264
commits into
nasa:devel
Choose a base branch
from
bocchino:fpp-v2.3.0a1
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
FPP v2.3.0a1 #3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move external state machine tests to state_machine/external
external --> external_instance
Add class diagram
Close up spaces in names with embedded variables
Increase code coverage
Increase code coverage
This directory no longer exists in fprime/devel
thomas-bc
reviewed
Dec 10, 2024
LeStarch
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the structure of FppTest
and reviewed the files outside of FppTest
. Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates FPP v2.3.0a1. It also makes the following changes to F Prime:
$
as necessary.Reviewing Notes
Notes and status from the in-person review on 11/20/24 are here: nasa/fpp#508 (comment).
To review code coverage on the tests, you can run
fprime-util check --coverage --all-sources
in the following directories:Code coverage is around 90-100% except in
fprime/FppTest/state_machine/internal_instance/initial
, where the coverage of the auto-generated component code is about 40%. This is because of the modular test design: these tests don't send signals to the state machines; only state machine initialization is tested. The code for sending signals is exercised in the other test suites.